| dsc_ | I made a context menu to copy messages to clipboard etc. | 14:00 |
|---|---|---|
| dsc_ | https://github.com/maemo-leste/conversations/blob/master/src/chatwindow.cpp#L397-L475 | 14:00 |
| dsc_ | which works fine in VM but I noticed some interesting behavior on D4 | 14:00 |
| dsc_ | if you dismiss the menu by clicking outside of it, conversations will not register any click events | 14:01 |
| dsc_ | test | 14:01 |
| dsc_ | as if control is not given back to the underlying app | 14:01 |
| fmg_d4 | but why would it not work on arm only? | 14:02 |
| dsc_ | im not sure | 14:03 |
| Wizzup | could be touch event vs mouse event | 14:04 |
| fmg_d4 | hmm, right | 14:04 |
| fmg_d4 | who renders the menu? xcb qpa? | 14:05 |
| Wizzup | no idea | 14:06 |
| dsc_ | its a qmenu, not sure | 14:06 |
| dsc_ | https://plak.infrapuin.nl/selif/d5u20ffy.png | 14:06 |
| dsc_ | looks like this | 14:06 |
| Wizzup | that looks broken theme wise | 14:08 |
| Wizzup | did you launch this over ssh? | 14:08 |
| dsc_ | no | 14:08 |
| Wizzup | ok | 14:08 |
| Wizzup | it should look like the menu in OMP | 14:08 |
| Wizzup | assuming that still works | 14:09 |
| fmg_d4 | btw, recently i have no sound in omp at all | 14:11 |
| fmg_d4 | no matter calls or not | 14:11 |
| dsc_ | also `QDesktopServices::openUrl(QUrl("https://bla.com", QUrl::TolerantMode));` yields "Unable to detect a web browser to launch" | 14:14 |
| dsc_ | im assuming it does some XDG stuff | 14:15 |
| fmg_d4 | use hildon api | 14:15 |
| fmg_d4 | hildon_uri_open | 14:15 |
| dsc_ | ty | 14:15 |
| freemangordon | dsc_: also, maybe it would be a good idea to not open browser for links to images, but embed them in the chat, but I guess that's for the future | 14:17 |
| dsc_ | freemangordon: yes I wanted to do HEAD to any link, determine content-type, then do embedding | 14:17 |
| dsc_ | but Wizzup hates my ideas | 14:18 |
| dsc_ | :-P | 14:18 |
| freemangordon | no need to do get request, you already have the mime type in the message part, no? | 14:18 |
| dsc_ | ah, for Tp messages | 14:19 |
| freemangordon | mhm | 14:19 |
| freemangordon | well, at least that's the theory, we are yet to see how that works in practice | 14:20 |
| freemangordon | but messages might be multi-part with different mime types for each part | 14:20 |
| dsc_ | regarding Tp media, we only handle TextChannel atm., we need to decide some things on how to handle them like saving them in rtcom or not | 14:21 |
| freemangordon | no, it is still text channel | 14:22 |
| freemangordon | but a message in that channel can have multiple parts, IIUC | 14:22 |
| freemangordon | but yeah, we have to decide how to handle that | 14:22 |
| dsc_ | https://telepathy.freedesktop.org/spec/index.html#Channel-Types | 14:23 |
| dsc_ | i looked into `org.freedesktop.Telepathy.Channel.Type.FileTransfer` earlier | 14:23 |
| dsc_ | needs further investigation | 14:24 |
| freemangordon | see https://telepathy.freedesktop.org/spec/Channel_Interface_Messages.html#Mapping:Message_Part | 14:24 |
| dsc_ | ah | 14:24 |
| freemangordon | mhm | 14:25 |
| dsc_ | interesting | 14:25 |
| freemangordon | I wonder if we can send an image over irc channel | 14:28 |
| Wizzup | no | 14:28 |
| Wizzup | you can't | 14:28 |
| Wizzup | dcc is single party and god please don't use dcc | 14:29 |
| fmg_d4 | dcc? | 14:29 |
| Wizzup | https://en.wikipedia.org/wiki/Direct_Client-to-Client | 14:29 |
| fmg_d4 | so, we can try xmpp to send images | 14:29 |
| fmg_d4 | or, last resort - facebook | 14:30 |
| Wizzup | yes, but it's quite pointless currently | 14:30 |
| Wizzup | since gabble is really old and doesn't use the more 'modern' ways to send files | 14:30 |
| dsc_ | :P | 14:30 |
| Wizzup | we need a more modern xmpp implementation in tp first, probably using qxmpp | 14:30 |
| fmg_d4 | but I wanted to see how others do it first, before extending haze | 14:31 |
| Wizzup | I would personally just hold off on trying to add special image handing currently | 14:31 |
| Wizzup | we have imo bigger things to tackle | 14:31 |
| fmg_d4 | right | 14:31 |
| dsc_ | [W] [chatwindow.cpp::478] "https://www.openid.net/certification/open-source-project-certification-policy/" - "No actions or XDG applications exist for the scheme 'https'" | 14:54 |
| dsc_ | ^-- with hildon_uri_open() | 14:55 |
| dsc_ | https://github.com/maemo-leste/conversations/blob/master/src/chatwindow.cpp#L476 | 14:55 |
| fmg_d4 | well, do you have ay browser installed? | 14:57 |
| fmg_d4 | what does xdg-open do for that url? | 14:57 |
| dsc_ | ah yes, jib didnt come with my VM it seems | 14:58 |
| dsc_ | it works now | 14:58 |
| dsc_ | well, it opens jib, but not the URL. | 14:58 |
| dsc_ | close enough. | 14:58 |
| fmg_d4 | well, jib shoul b fixed iguess ten | 14:58 |
| dsc_ | yes | 14:59 |
| dsc_ | $ cat /proc/22225/cmdline | 15:00 |
| dsc_ | jib | 15:00 |
| dsc_ | shouldnt it be passing something through argv? | 15:00 |
| dsc_ | sry I dont know how this XDG stuff works :P | 15:00 |
| fmg_d4 | it should | 15:01 |
| fmg_d4 | afaik it should pass the url | 15:01 |
| dsc_ | ok | 15:01 |
| dsc_ | ill investigate | 15:02 |
| Wizzup | try xdg-open https://bla and also x-www-browser https://bla | 15:06 |
| Wizzup | (make it a real url ofc) | 15:06 |
| Wizzup | dsc_: maybe the jib.desktop needs tweaks for xdg params, not sure | 15:07 |
| dsc_ | Wizzup: there is no xdg-open | 15:10 |
| dsc_ | `x-www-browser` works | 15:11 |
| dsc_ | ill try to get `hildon_uri_open` to work, if it takes too long ill just do QProcess `x-www-browser` ? | 15:12 |
| fmg_d4 | it works | 15:14 |
| fmg_d4 | for sure I can open linsk from emails | 15:14 |
| dsc_ | error: invalid use of incomplete type ‘HildonURIAction’ 470 | action->type = HILDON_URI_ACTION_XDG; | 15:18 |
| dsc_ | i dont know how to use this API sorry | 15:18 |
| dsc_ | its C crap | 15:18 |
| freemangordon | just RTFM | 15:19 |
| freemangordon | install libhildonmime0-doc | 15:20 |
| dsc_ | thx | 15:23 |
| freemangordon | "This is optional and NULL can be specified to use the default action instead." | 15:23 |
| freemangordon | open /usr/share/gtk-doc/html/libhildonmime/index.html in a browser | 15:24 |
| dsc_ | tried with NULL action just now, same behavior (jib without argv) | 15:25 |
| freemangordon | because it makes dbus call | 15:25 |
| freemangordon | if jib is not properly registered, that'd be the result | 15:26 |
| freemangordon | lemme try with xdg-open here in my vm | 15:26 |
| dsc_ | dbus traffic looks OK | 15:26 |
| freemangordon | here xdg-open launches chromium | 15:27 |
| freemangordon | what does xdg-open do in your VM? | 15:27 |
| freemangordon | sudo apt install xdg-utils | 15:28 |
| dsc_ | https://bpa.st/raw/5KBA | 15:29 |
| dsc_ | (via hildon_open_uri) | 15:29 |
| dsc_ | xdg-open works | 15:29 |
| freemangordon | lemme see what happens | 15:34 |
| freemangordon | I guess your desktop file is broken, perhaps it is missing some %s or somesuch | 15:35 |
| freemangordon | jib does not work with modest as well | 15:35 |
| dsc_ | https://bpa.st/raw/QOMA | 15:35 |
| dsc_ | > Exec=jib | 15:36 |
| dsc_ | %s there? | 15:36 |
| freemangordon | yeah, perhaps that is broken, lemme see | 15:36 |
| freemangordon | no idea, looking at what chromium does | 15:36 |
| dsc_ | thanks | 15:36 |
| freemangordon | Exec=/usr/bin/chromium %U | 15:37 |
| dsc_ | ok cool | 15:37 |
| dsc_ | ill fix it in jib | 15:37 |
| freemangordon | lemme try it first | 15:37 |
| freemangordon | yeah, that fixes it | 15:38 |
| dsc_ | freemangordon: are you using chromium on d4? | 15:43 |
| fmg_d4 | yes | 15:43 |
| freemangordon | dsc_: https://github.com/maemo-leste/conversations/commit/38d9318722f705c41f1d72b8951fd6cb949f8bb8 | 16:48 |
| freemangordon | I guess this is not the latest version, right? | 16:48 |
| freemangordon | as you don;t really need to call hildon_uri_get_default_action_by_uri() or anything, just pass NULL to hildon_uri_open() | 16:48 |
| dsc_ | freemangordon: ok, will fix later | 17:22 |
| dsc_ | also need to fix https://github.com/maemo-leste/conversations/blob/master/src/conversations.cpp#L22 | 17:32 |
| freemangordon | mhm | 17:32 |
| dsc_ | would be nice to make a stable release, this week | 17:33 |
| freemangordon | also, main window should not be made visible on new message | 17:33 |
| freemangordon | only the chat window | 17:33 |
| dsc_ | ah, ok | 17:33 |
| dsc_ | https://github.com/maemo-leste/conversations/blob/master/src/mainwindow.cpp#L228 | 17:33 |
| dsc_ | (pasting for myself later) | 17:34 |
| freemangordon | I'll try to find some time to make notifications work properly (like, overlaying the notification on the chat window) | 17:34 |
| dsc_ | nice :) | 17:35 |
| arno11 | Wizzup: i pushed the 3 deps for drnoksnes in extras: gbp, changelog, control and tag seem ok but they don't appear in jenkins. Any idea or tips ? | 18:21 |
| sicelo | arno11: look at the jenkins log | 18:36 |
| sicelo | should be able to see if it's visiting the correct tag | 18:36 |
| arno11 | ah ok ty | 18:37 |
| freemangordon | Wizzup: https://github.com/maemo-leste-upstream-forks/voicecall/blob/master/voicecall.pro#L14 | 19:56 |
| freemangordon | are you sure this is the correct path? | 19:56 |
| freemangordon | and not /usr/share/telepathy/clients/ ? | 19:57 |
| Wizzup | let me look | 19:57 |
| freemangordon | conversations install to clients | 19:57 |
| freemangordon | as is telepathy-logger | 19:57 |
| Wizzup | ah, client vs clients | 19:58 |
| freemangordon | mhm | 19:58 |
| Wizzup | yes, that appears to be a mistake | 19:58 |
| Wizzup | don't know what the consequences of the mistake are, but that needs fixing | 19:58 |
| freemangordon | mhm | 19:59 |
| Wizzup | want me to fix it? | 19:59 |
| Wizzup | it looks like on my droid4 I have the file in client and clients | 20:00 |
| Wizzup | probably manually insalled | 20:00 |
| freemangordon | yes, please fix it | 20:00 |
| freemangordon | I am still on the abook error, findint that was a side-effect :) | 20:00 |
| Wizzup | building now | 20:02 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
