| dsc_ | freemangordon: I removed config stuff and AccountChannel from tp: https://github.com/maemo-leste/conversations/tree/tp-configstate | 04:29 |
|---|---|---|
| dsc_ | its much better | 04:29 |
| dsc_ | still wip | 04:29 |
| freemangordon | dsc_: cool | 07:52 |
| freemangordon | dsc_: while on it, please, please, for the life of the kittens, do not use 'auto' unless strictly necessary | 07:53 |
| freemangordon | also, instead of using isNull() on shared pointers, there should be operator bool, i.e. if (!shared_pre.isNull()) {} can be done as if (shared_ptr) {} | 07:54 |
| freemangordon | umm, sorry for the typo, I meant "if (!shared_ptr.isNull()) {} can be done as if (shared_ptr) {}" | 07:56 |
| freemangordon | https://github.com/maemo-leste/conversations/compare/master...tp-configstate#diff-e2170e85790184b8a7e3cc950589dff0faf126adff727f418c48e763ad8a1e3dR22 | 07:58 |
| freemangordon | there is QStandardPaths::ConfigLocation and QStandardPaths::GenericConfigLocation and QStandardPaths::AppConfigLocation etc | 07:59 |
| freemangordon | no need to create config path by hand, unless I am missing something, see https://doc.qt.io/qt-6/qstandardpaths.html | 08:00 |
| freemangordon | why ConfigState() class, instead of just using QSettings? with QSettings you can store QVariant, and you can put there whatever structure you may need | 08:02 |
| freemangordon | ugh, no, this is a recipe for disaster https://github.com/maemo-leste/conversations/compare/master...tp-configstate#diff-87db68d7596ffb0dfea5735881430cc11e7a6c780e8de85a530e1654839077cdR152 | 08:04 |
| freemangordon | never use raw pointers as keys or whatever | 08:05 |
| freemangordon | make that list map | 08:07 |
| freemangordon | or use local_id or remote_id something when iterating | 08:09 |
| Wizzup | freemangordon: what is wrong with 'auto' ? | 11:02 |
| freemangordon | code becomes unreadable | 11:05 |
| freemangordon | so, unless it is lamda, auto *must* not be used in my book | 11:05 |
| freemangordon | maybe there is one more legitimate use case, but I can't remember | 11:06 |
| freemangordon | if we are to use auto, why not just switch to js and call it a day? | 11:07 |
| Wizzup | I mean fair enough I guess | 11:13 |
| freemangordon | umm, can't parse :) | 11:14 |
| uvos__ | sometimes deeply nested templateing can make it really undesirable to list the type more than once | 11:15 |
| uvos__ | but ofc your working a larger problem with auto there | 11:15 |
| freemangordon | right, that was the other use case | 11:15 |
| uvos__ | *working around | 11:15 |
| freemangordon | :nod: | 11:15 |
| freemangordon | you'd better have typedef-ed that | 11:16 |
| freemangordon | but yeah, if it is very long type, auto is fine I guess | 11:16 |
| uvos__ | but yeah i dont like "auto item = getItem(local_uid, remote_id);" either | 11:18 |
| uvos__ | since now i have to go figure out what getItem returns | 11:18 |
| freemangordon | exactly | 11:19 |
| uvos__ | feals like python xD | 11:19 |
| uvos__ | who-knows-what-this-is | 11:19 |
| freemangordon | == "unreadable code" | 11:19 |
| Wizzup | our user guide, shall we host it on maedevu.maemo.org or somewhere else | 11:56 |
| * unic0rn lurks out, shivers, hides back and hugs his tcl/tk | 11:57 | |
| Wizzup | leste.maemo.org is an option but it's a wiki too | 11:57 |
| Wizzup | freemangordon: so for debugging audio issues with sofiasip I guess we have: voicecall-manager, telepathy-rakia, various gst dependencies/components, pulseaudio, and the different sip settings? | 12:01 |
| Wizzup | and I guess farstream is in voicecall-manager | 12:11 |
| freemangordon | Wizzup: I have absolutely NFC how all this is supposed to work | 12:20 |
| Wizzup | freemangordon: ok, so we're in the same boat then | 12:27 |
| dsc_ | freemangordon> umm, sorry for the typo, I meant "if (!shared_ptr.isNull()) {} can be done as if (shared_ptr) {}" | 13:03 |
| dsc_ | ^-- I did that but didnt work hence I used isNull() | 13:03 |
| dsc_ | freemangordon> why ConfigState() class, instead of just using QSettings? | 13:05 |
| dsc_ | ^-- because I want to write state.json which is a file that can be hand-edited, based on an earlier request by Wizzup | 13:06 |
| dsc_ | < freemangordon> ugh, no, this is a recipe for disaster | 13:07 |
| dsc_ | ^-- your link is broken, I dont know what you a referring to | 13:07 |
| dsc_ | your reaction makes it seem like this code is terrible, which it is not. I will refrain from posting WIPs to you. | 13:08 |
| dsc_ | i shared it to share the general architecture | 13:09 |
| dsc_ | and ill use `auto` whenever I want ;) | 13:10 |
| dsc_ | < freemangordon> there is QStandardPaths::ConfigLocation and QStandardPaths::GenericConfigLocation | 13:13 |
| dsc_ | why even mention this, this code is about Tp, I am well aware aboug XDG paths, you want me to fix everything in one commit? :P | 13:13 |
| dsc_ | its just being pedantic for no reason | 13:14 |
| dsc_ | regarding `auto getItem`, the API is easy to follow; add, get, delete, save, load: https://github.com/maemo-leste/conversations/blob/tp-configstate/src/lib/state.h | 13:25 |
| freemangordon | dsc_: weird that the link is broken, anyways, I was referring to channelByName() implementation | 13:41 |
| freemangordon | for(TelepathyAccount *ta: accounts) { | 13:41 |
| freemangordon | dsc_: also, my comments were not meant to offend you, it is a pity you take it like that | 13:42 |
| dsc_ | QList<TelepathyAccount*> accounts; | 13:43 |
| freemangordon | dsc_: re auto - it makes it way harder to read the code, esp when doing peer review os a commit | 13:43 |
| freemangordon | *of a | 13:43 |
| dsc_ | this one right? ought to be wrapped in Ptr | 13:43 |
| dsc_ | SharedPtr | 13:44 |
| dsc_ | https://github.com/maemo-leste/conversations/blob/master/src/lib/tp.h#L206 | 13:44 |
| dsc_ | we've had this forever, and yes its bad, ill do something about it | 13:45 |
| inky | if today anyone would like to help me to install maemo on mz617, i think i can concentrate on it in nearest hours. | 13:59 |
| Wizzup | there's no documentation yet, so don't brick it | 14:01 |
| Wizzup | like I said, I am working on it, I likely won't be able to help if you brick it by doing it before we have documentation | 14:01 |
| Wizzup | also you need the -experimental kernel for it to boot and the current images do not have this | 14:02 |
| freemangordon | dsc_: sorry, got a call | 14:03 |
| freemangordon | yes, this one QList<TelepathyAccount*> accounts; | 14:03 |
| freemangordon | dsc_: again re auto - ofc I cannot tell you how to code, but, most-probably at some point I'll change all autos to proper types | 14:04 |
| freemangordon | using auto for bool ... | 14:04 |
| freemangordon | a side note - I was thinking you have been long enough in BG so there is no need for me to be politically correct. Obliviously that's not the case, so I'll watch my tone more strictly for the future. | 14:07 |
| dsc_ | hehe | 14:07 |
| freemangordon | no, really, I was kind of surprised by your reaction, however, I'll watch my comments | 14:08 |
| dsc_ | freemangordon: https://berthub.eu/articles/pretty-ok.png | 14:08 |
| freemangordon | exactly | 14:09 |
| dsc_ | please, just be yourself, no need to change | 14:10 |
| dsc_ | and in return i will keep telling you you are being pedantic | 14:10 |
| dsc_ | its fine | 14:10 |
| dsc_ | :P | 14:11 |
| freemangordon | ok, we have a deal, as long as there are no hard feelings | 14:11 |
| dsc_ | no no | 14:11 |
| freemangordon | and we are moving ahead | 14:11 |
| freemangordon | :deal: | 14:11 |
| dsc_ | regarding isNull(), ill fix that too because https://godbolt.org/z/6qrzKGf8x | 14:38 |
| freemangordon | maybe my browser is old, but that link renders no usable info | 14:40 |
| freemangordon | I see just some top bar "compiler explorer" and thats all | 14:40 |
| dsc_ | https://plak.infrapuin.nl/selif/a5ltu6tp.png | 14:41 |
| dsc_ | i was observing other results last night but you are correct, isNull should not be needed | 14:41 |
| freemangordon | hmm, wait | 14:42 |
| freemangordon | ah, right | 14:42 |
| freemangordon | my bad | 14:42 |
| freemangordon | however, you should be able to do FooPtr p; if (p) {} | 14:43 |
| dsc_ | yes | 14:45 |
| havenoname | hi all | 15:17 |
| dsc_ | hi | 15:20 |
| kiva | sicelo: I did not find Fremantle fingerterm, but more resent source found quite obvious place: https://github.com/sailfishos/fingerterm | 15:22 |
| sicelo | ah, now i remember that when i used it on N900, i was running Meego CE | 16:43 |
| dsc_ | Wizzup: https://github.com/maemo-leste/conversations/blob/tp-configstate/src/lib/tp.cpp#L248-L298 | 16:55 |
| dsc_ | I think this works without using `requestsSatisfied` (old version: https://github.com/maemo-leste/conversations/blob/master/src/lib/tp.cpp#L228-L302 ) | 16:55 |
| dsc_ | but I will verify | 16:55 |
| Wizzup | yes, please don't rewrite the core tp stuff too much, I spent a lot of time figuring out why we need to do all these things | 16:59 |
| Wizzup | with various edge cases that you might not run into here | 16:59 |
| Wizzup | and I honestly have no idea why it was needed anymore but it definitely was at the time | 16:59 |
| Wizzup | so please don't get rid of it :( | 16:59 |
| Wizzup | although it would make sense that requests satisfied is something we write, not read | 17:00 |
| Wizzup | Requests_Satisfied — ao | 17:01 |
| Wizzup | The requests satisfied by these channels. | 17:01 |
| Wizzup | Rationale: | 17:01 |
| Wizzup | If the handler implements Requests, this tells it that these channels match previous AddRequest calls that it may have received. | 17:01 |
| Wizzup | There can be more than one, if they were EnsureChannel requests. | 17:01 |
| dsc_ | yes | 17:16 |
| dsc_ | however I did check various Tp clients on Github and could not find one that actually uses `requestsSatisfied` | 17:16 |
| dsc_ | like the KDE one etc. | 17:16 |
| dsc_ | but we'll see | 17:16 |
| Wizzup | how will we see? | 17:19 |
| dsc_ | by first understanding what `requestsSatisfied` is, or why we are the only one using it, and to see if everything works without using it | 17:23 |
| dsc_ | > If the handler implements Requests, this tells it that these channels match previous AddRequest calls | 17:24 |
| dsc_ | e.g: are we doing AddRequest calls | 17:24 |
| dsc_ | if so, is it relevant to us to match them handleChannels() | 17:24 |
| dsc_ | https://bugs.freedesktop.org/show_bug.cgi?id=77986 | 17:29 |
| dsc_ | > The main purpose of Requests_Satisfied is matching up channels you're being asked to handle with either requests you started (if you create/ensure channels), or channels whose channel request you were previously asked to approve (if you're an Observer or Approver) | 17:29 |
| dsc_ | > If you're doing either of those, you have a TpChannelRequest already, it's probably already prepared too, and all you need to do is match it by object path or by object identity, for instance looking it up in a hash table { channel request => chat window }. | 17:29 |
| dsc_ | sounds like `Requests_Satisfied` is a way to make sure handleChannels is only handling the channels it previously requested (in the case there are multiple observers) | 17:30 |
| Wizzup | dsc_: what about ensuring that a channel doesn't already exist | 18:16 |
| dsc_ | Wizzup: channels are unique on TargetID (remote_uid in practice) | 18:41 |
| dsc_ | and we're only handling TextChannels at this point | 18:42 |
| Wizzup | https://maedevu.maemo.org/docs/userguide/ | 20:15 |
| Wizzup | ^^ | 20:15 |
| freemangordon | nice :) | 20:21 |
| Wizzup | dsc_: in the latest stable release the bug is still there btw | 20:24 |
| Wizzup | dsc_: https://wizzup.org/bug.png | 20:25 |
| Wizzup | this happens for every sms | 20:25 |
| Wizzup | well, stable, I mean devel release | 20:26 |
| Wizzup | freemangordon: just for the record the repo I made on github might not be 'official' one atm so I am not sure if the guy will see it but I will let him know | 20:40 |
| Wizzup | brtw | 20:40 |
| Wizzup | btw | 20:40 |
| Wizzup | apt install maemo-user-guide | 20:40 |
| freemangordon | ok | 20:40 |
| freemangordon | I just closed the issue anyways | 20:41 |
| Wizzup | I will update hildon-desktop's user-guide.desktop now | 20:41 |
| Wizzup | root@maindroid:/usr/share/applications/hildon# grep Exec user-guide.desktop | 20:41 |
| freemangordon | great | 20:41 |
| Wizzup | Exec=x-www-browser file:///usr/share/doc/maemo-user-guide/html/index.html | 20:41 |
| Wizzup | agreed? | 20:41 |
| Wizzup | this works with jib and dillo (n900) | 20:41 |
| freemangordon | isn't it better to open the pdf? | 20:41 |
| Wizzup | no, because our pdf reader is shit | 20:42 |
| Wizzup | :) | 20:42 |
| freemangordon | is it? | 20:42 |
| Wizzup | it crashes frequently and I haven't given it any more love | 20:42 |
| freemangordon | never had issues, but ok | 20:42 |
| Wizzup | even locking the screen will make it crash | 20:42 |
| Wizzup | really? | 20:42 |
| Wizzup | on leste? | 20:42 |
| freemangordon | mhm | 20:42 |
| freemangordon | not that used it much :) | 20:42 |
| Wizzup | that's probably why | 20:42 |
| freemangordon | yeah | 20:42 |
| Wizzup | I use it every time I take the bus or whatever | 20:42 |
| Wizzup | and it is very crash prone | 20:42 |
| Wizzup | there is also epub version which might be ok on n900, maybe better than dillo, but, eh. | 20:42 |
| freemangordon | ok. | 20:42 |
| Wizzup | ftr I did most of the pdf reader porting so the blame probably falls on me ;) | 20:43 |
| freemangordon | good to know :) | 20:45 |
| Wizzup | dsc_: and re: the bug, incoming sms is not a group chat and also not a chat message (different icon) | 20:46 |
| Wizzup | and it goes away upon conversations restart | 20:46 |
| freemangordon | ok, I am going MIA, see ya in 2 weeks :) | 20:46 |
| Wizzup | ttyl | 20:53 |
| Wizzup | any objections to running this in leste-config-n900 postinst? | 21:13 |
| Wizzup | update-alternatives --install /usr/bin/x-www-browser x-www-browser /usr/bin/dillo 100 | 21:13 |
| dsc_ | Wizzup: lets fix this in this commit im working on | 21:20 |
| dsc_ | but I will need info | 21:21 |
| dsc_ | brb 30min | 21:21 |
| dsc_ | Wizzup: since made significant changes to both tp.cpp and the way overview renders | 21:53 |
| dsc_ | lets try this on the new version first | 21:53 |
| dsc_ | but not now, I am dealing with quite a big refactor | 21:54 |
| dsc_ | im in the process of testing IRC and XMPP and the functionality related to that | 21:55 |
| dsc_ | after that I can push changes, at which point we can see what exactly happens to SMS | 21:55 |
| Wizzup | okay, please also test sms if you can, assuming you have a second sim card | 22:05 |
| dsc_ | ugh finally found the leak | 23:48 |
| dsc_ | but thats good news | 23:49 |
| dsc_ | https://github.com/maemo-leste/conversations/blob/master/src/lib/rtcom.cpp#L102 | 23:50 |
| dsc_ | should use `qtrtcom::rtcomel()` | 23:50 |
| dsc_ | not sure how it was missed | 23:50 |
| dsc_ | ok great :) | 23:52 |
| dsc_ | Wizzup: sorry I dont have a 2nd SIM right now | 23:55 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
