| freemangordon | Wizzup: I am starting to think it is not tp plugins that has to be fixed, but rather conversations does not properly ack incomming messages | 07:20 |
|---|---|---|
| freemangordon | as I see the same issue with tp-haze and FB | 07:20 |
| freemangordon | but yeah, has to debug that | 07:20 |
| freemangordon | dsc_: does not seem to work for haze/FB | 07:39 |
| freemangordon | I think I know what happens, but not how to properly fix it :) | 07:40 |
| freemangordon | recently, I implemented chat "seen" support in haze, which relies on chat state. And it does not make messages as seen until chat state is "active" or "typing" etc | 07:41 |
| freemangordon | s/make/mark | 07:41 |
| freemangordon | dsc_: I don;t think your 'duplicates' fix is proper - why do you ignore scrollback messages only? | 07:43 |
| freemangordon | duplicated messages come as new, at least from haze | 07:43 |
| freemangordon | hmm, no idea how to properly fix that | 07:44 |
| * freemangordon wonders if we shall move to pidgin 3 | 08:02 | |
| arno11 | freemangordon: hi, i'm a bit confused: you receive duplicate msgs from haze/FB ? | 08:03 |
| freemangordon | yes | 08:03 |
| freemangordon | what happens is: | 08:03 |
| freemangordon | 1. couple of messages arrive from FB | 08:03 |
| freemangordon | 2. those are send from haze to UI and UI acks them | 08:04 |
| freemangordon | 3. internet connection reconnects | 08:04 |
| freemangordon | messages from (1) are received again, as they were not marked as read | 08:04 |
| freemangordon | pidgin has no concept of marking messages as received | 08:05 |
| freemangordon | OTOH, we cannot mark messages as read simply because they were put in the database | 08:05 |
| arno11 | ok | 08:06 |
| freemangordon | and purple 2.x has no concept of message id or anything, so we cannot send "received" receipt per message | 08:11 |
| freemangordon | while purple 3.x has | 08:11 |
| freemangordon | it supports message ids and whatnot | 08:11 |
| freemangordon | so I am tempted to try to port haze to libpurple 3 | 08:12 |
| freemangordon | though it is way easier to teach UI to just ignore those | 08:20 |
| arno11 | indeed, sounds an easier way | 08:25 |
| Cat_ | freemangordon i managed to dd the image to the sd card but i dont know how to boot from it | 09:36 |
| Cat_ | it seems that samsung devices deprecated booting from sdcards and instead support only booting from recovery/system partitions. | 09:38 |
| Cat_ | Wizzup thanks i havent tried the image builder yet and i already have the phone running postmarketOS with 6.8.1 kernel | 10:29 |
| Wizzup | freemangordon: I do not think libpurple3 is ready yet, is it? | 10:29 |
| Wizzup | I am in the pidgin channel and the devs themselves do not seem to be using it yet even | 10:30 |
| Wizzup | Cat_: yeah so try to look at what postmarket os does then, how it boots the sd card and such | 10:31 |
| Wizzup | leste just needs you to load the kernel and a sd card or partition to install leste to | 10:31 |
| Cat_ | I think i might be able to boot it from the recovery partition | 10:31 |
| Cat_ | if the sdcard option doesnt work | 10:32 |
| Wizzup | well, what does pmos do ? | 10:32 |
| Cat_ | i have no idea, it boots from the internal memory | 10:33 |
| Wizzup | they do not have some bootloader? | 10:33 |
| Cat_ | They boot the OS from the recovery, https://wiki.postmarketos.org/wiki/Installation_from_recovery_mode this is what i followed | 10:35 |
| Wizzup | ok, this kinds of hits the boundaries of my android knowledge, so it will take some investigation to figure out how to do it | 10:39 |
| freemangordon | Wizzup: didn't we have some pmos guys in the channel? | 11:41 |
| freemangordon | sicelo: ^^^ | 11:41 |
| uvos__ | They dont boot from recovery | 11:58 |
| uvos__ | recovery zips are simply scripts that are executed by the recovery that can do thinks like write new images to partitions | 11:58 |
| uvos__ | android bootloaders boot from android boot imgaes off of the boot partition only | 11:59 |
| uvos__ | android boot images are a special but well documented/tooled format which packages the kernel, somtimes dts, cdmline etc | 12:00 |
| uvos__ | you must simply create a boot image for your device with the kernel source of your device and androids tools and set the cmdline to something apropriate to boot from the sdcard | 12:01 |
| uvos__ | flashing your boot.img is easiest via fastboot, for simple cases this makes more sense than to go the whole update.zip route | 12:02 |
| uvos__ | the boot.img format is described here https://source.android.com/docs/core/architecture/bootloader/boot-image-header | 12:03 |
| uvos__ | the tool to create a boot.img from its componatnts is https://android.googlesource.com/platform/system/tools/mkbootimg/ | 12:04 |
| Cat_1 | @uvos__ thanks, ill look it up | 12:32 |
| kiva | Is osso-notes come available to Application Manager or would it be default in next images? | 14:34 |
| freemangordon | kiva: isn't it closed-source? | 16:30 |
| sicelo | https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/merge_requests/672 | 17:58 |
| sicelo | N900 booted off xkb-data. | 17:58 |
| Wizzup | maybe just comment on it? | 18:09 |
| Wizzup | ah you did | 18:09 |
| Wizzup | sicelo: maybe we can also mention adding the droid 4 | 18:10 |
| Wizzup | freemangordon: like, if you port to libpurple3, then we would also need to upgrade all our current/existing libpurple2 plugins | 18:19 |
| freemangordon | Wizzup: yeah, not a good option | 18:20 |
| Wizzup | unless I am mistaken and most are on libpurple3 (I don't think so) | 18:20 |
| freemangordon | I'll fix the UI | 18:22 |
| Wizzup | hm? | 18:23 |
| freemangordon | conversations | 18:26 |
| freemangordon | this https://github.com/maemo-leste/conversations/commit/1015daacd3a278706cf167bf43f99ed0121e6fa6 | 18:26 |
| freemangordon | shall affect all messages, not scrollback only | 18:26 |
| dsc_ | (y) | 18:28 |
| dsc_ | im going to build a new conversations | 20:23 |
| dsc_ | it fixes the message status icons in the overview | 20:54 |
| dsc_ | as well as chat clearing functionality | 20:54 |
| dsc_ | and some other fixes | 20:54 |
| freemangordon | dsc_: https://github.com/maemo-leste/conversations/commit/1015daacd3a278706cf167bf43f99ed0121e6fa6#diff-87db68d7596ffb0dfea5735881430cc11e7a6c780e8de85a530e1654839077cdR474 | 23:03 |
| freemangordon | do we really need channels.contains(channel_str) ? | 23:03 |
| freemangordon | I don;t get the logic here | 23:03 |
| dsc_ | freemangordon: access by key after that line so checking for it | 23:04 |
| freemangordon | ok, bu why do we return if that condition faile? | 23:04 |
| freemangordon | *fails | 23:04 |
| freemangordon | that means that we ignore unconditionally any scrollback messages if there are no previous messages, no? | 23:05 |
| dsc_ | let me think | 23:05 |
| dsc_ | yes its wrong | 23:06 |
| dsc_ | from first glance its wrong but its ok because this branch never hits | 23:07 |
| dsc_ | either way it should be removed :P | 23:07 |
| freemangordon | what about https://pastebin.com/8FN8zLK4 | 23:07 |
| freemangordon | no, why this shall be removed? | 23:07 |
| dsc_ | that paste is ok, yeah | 23:08 |
| freemangordon | dsc_: I'll push what I think is a proper fix if you don;t object | 23:08 |
| freemangordon | if you object, I'll make a PR, just LMK | 23:09 |
| dsc_ | sure :) | 23:09 |
| freemangordon | sure what? puch? | 23:09 |
| dsc_ | i think in general you can just push what you want, 9/10 times its good | 23:09 |
| freemangordon | push | 23:09 |
| dsc_ | no need to ask | 23:09 |
| freemangordon | well, it is you that maintains that, I prefer to have your opinion anyways | 23:10 |
| dsc_ | true | 23:10 |
| freemangordon | but ok | 23:10 |
| dsc_ | freemangordon: did you try chat removal yet? | 23:11 |
| dsc_ | maybe you have some test channels you can get rido f | 23:11 |
| freemangordon | yes, I did | 23:11 |
| freemangordon | hmm, wait | 23:11 |
| freemangordon | no, I tested chat clear, not removal | 23:12 |
| Wizzup | how is it different | 23:12 |
| freemangordon | I am not sure what chat removal is supposed to do | 23:12 |
| dsc_ | with clear the item stays in the overview, albeit empty | 23:12 |
| freemangordon | well, but they are not tehre if you restart conversations | 23:12 |
| dsc_ | with clear they will be | 23:13 |
| dsc_ | else you wouldnt be able to open a chatwindow of a chat that does not contain any chats yet | 23:13 |
| freemangordon | not really | 23:13 |
| freemangordon | if you want to open a chat, you can always do it from the contact | 23:13 |
| freemangordon | and that's the proper way imo | 23:14 |
| Wizzup | is this true for group chats? | 23:14 |
| freemangordon | no, I guess you have to select it from the (non-existing) list of groups | 23:15 |
| freemangordon | not sure what fremantle conversation do | 23:15 |
| freemangordon | but I would guess they remove group chats from the list | 23:15 |
| freemangordon | dsc_: just tried 'delete chat' | 23:16 |
| freemangordon | did nothing | 23:16 |
| freemangordon | umm... | 23:16 |
| freemangordon | did nothing in the main window | 23:17 |
| freemangordon | the chat remains there, along with the last message | 23:17 |
| dsc_ | ^ thats a removal of a groupchat | 23:17 |
| dsc_ | freemangordon: what kind of chat did you remove? | 23:18 |
| Wizzup | I think 'clear chat' should probably just delete it entirely and do the same as delete, I am not sure if we need to differentiate | 23:19 |
| freemangordon | И агрее | 23:20 |
| freemangordon | oops | 23:20 |
| freemangordon | I agree | 23:20 |
| dsc_ | that behavior would differ from most chat applications | 23:20 |
| freemangordon | so? | 23:21 |
| dsc_ | clearing history versus deletion | 23:21 |
| freemangordon | what exactly is "deletion"? | 23:21 |
| freemangordon | leaving the chat? | 23:21 |
| dsc_ | delete is clear + leave + remove from overview | 23:21 |
| Wizzup | imo if the messages are gone, why would it remain in the overview? | 23:22 |
| freemangordon | what doe sit mean to 'leave' a non-group chat? | 23:22 |
| freemangordon | Wizzup: :nod: | 23:22 |
| dsc_ | groupchats must be listed in the overview regardless of any associated rtcom db entries | 23:23 |
| freemangordon | why would they, unless set for auto-join? | 23:23 |
| dsc_ | if there are no messages, it wouldnt be listed after a conversations restart | 23:23 |
| freemangordon | and that's ok | 23:23 |
| freemangordon | but, it must be consistent | 23:24 |
| freemangordon | so, if after restart, empty conversations are not listed, why would they be listed after clear/delete? | 23:24 |
| freemangordon | this is inconsistent | 23:24 |
| dsc_ | no, they are listed | 23:25 |
| freemangordon | if empty? | 23:25 |
| dsc_ | yes | 23:25 |
| freemangordon | ok, but not peer-to-peer ones | 23:25 |
| freemangordon | so, I think taht at least person-to-person chats shall be removed from the list | 23:26 |
| dsc_ | regarding p2p I'd have to check | 23:26 |
| freemangordon | for group chats not sure | 23:26 |
| freemangordon | well, now I have 2 separate chats with my GF :D | 23:26 |
| dsc_ | how? | 23:26 |
| freemangordon | after delete | 23:27 |
| Wizzup | disconnect between rtcom db and our model I guess | 23:27 |
| dsc_ | ugh :) | 23:27 |
| Wizzup | this is also what happened/happens with sms | 23:27 |
| Wizzup | (let me upgrade and test) | 23:27 |
| freemangordon | the old one remained and new one appeared :) | 23:27 |
| Wizzup | I think it would be the most simple to stay in sync with rtcom db if we can somehow | 23:28 |
| Wizzup | maybe we even reload overview screen from rtcom after a delete for example | 23:28 |
| freemangordon | yeah, restart does not help | 23:28 |
| Wizzup | oh | 23:28 |
| Wizzup | that means there's something funny in the db then? | 23:28 |
| freemangordon | mhm | 23:28 |
| dsc_ | Wizzup: we do all these things | 23:28 |
| dsc_ | overview has 3 sources | 23:28 |
| dsc_ | rtcom, tp, savedUserCfg | 23:28 |
| Wizzup | what does it get from tp? | 23:28 |
| dsc_ | these questions are very hard for me to quickly answer, as it is quite a complex thing | 23:29 |
| dsc_ | but in general, I had the situation where you joined a groupchat, exit conversations, open again, and it wouldnt show up | 23:29 |
| dsc_ | I think it should always show the groupchat you are in | 23:30 |
| dsc_ | regardless of offline/online state | 23:30 |
| Wizzup | maybe there can be a special filter with all (open) group chats | 23:30 |
| dsc_ | and regardless of any messages present in rtcom db | 23:30 |
| Wizzup | (not sure) | 23:30 |
| dsc_ | so regarding clear/removal | 23:31 |
| dsc_ | in irssi its: | 23:31 |
| dsc_ | /clear | 23:31 |
| dsc_ | /wc | 23:31 |
| dsc_ | :D | 23:32 |
| dsc_ | thats what I did | 23:32 |
| dsc_ | we can decide to can one of those if people dont like it | 23:32 |
| dsc_ | I think its quite intuitive | 23:32 |
| dsc_ | e.g sometimes you want to get rid of some chat history but stay in the groupchat | 23:33 |
| freemangordon | dsc_: I think group chats shall remain only if auto-join is enabled | 23:33 |
| freemangordon | right | 23:33 |
| freemangordon | so, for group chats maybe you just clear the history | 23:33 |
| freemangordon | but in any case, you dont; close the chat window | 23:34 |
| freemangordon | and for p2p you remove it from the list | 23:34 |
| freemangordon | (and don't close the window) | 23:34 |
| dsc_ | freemangordon: yeah, that makes sense | 23:35 |
| Wizzup | btw /clear in irssi doesn't delete anything from logs you might have but yeah | 23:35 |
| dsc_ | freemangordon: so if auto-join is disabled, and you press 'clear', you then close the chatwindow - you are still in the groupchat on Tp, but you wont see it in the overview, correct? | 23:38 |
| freemangordon | no, auto-join idea was bad | 23:39 |
| Wizzup | what do you mean? | 23:39 |
| freemangordon | just leave group chats in the list and remove p2p ones | 23:39 |
| Wizzup | ah ok that was in response to your idea | 23:40 |
| freemangordon | right | 23:40 |
| dsc_ | ah ok | 23:40 |
| freemangordon | maybe remove group chats when you leave the group | 23:40 |
| freemangordon | hmm, no | 23:40 |
| dsc_ | if we keep groupchats in the overview, how do you get rid of them? | 23:40 |
| freemangordon | only remove group chats if you have left the group and clear the conversations :D | 23:41 |
| freemangordon | s/conversations/history | 23:41 |
| dsc_ | right | 23:41 |
| freemangordon | can't think of anything better now | 23:41 |
| Wizzup | so this could rely just on rtcom and tp (for currently active channels) then | 23:42 |
| freemangordon | no, I think this will use the saved config too | 23:42 |
| dsc_ | something tells me there will be situations where just relying on those 2 will yield confusing results | 23:42 |
| freemangordon | because on startup you have no other source for group chtas, no? | 23:42 |
| dsc_ | right | 23:43 |
| Wizzup | the config will tell you what to join | 23:43 |
| Wizzup | not what to render | 23:43 |
| freemangordon | it will tell you to show empty group chats in the list | 23:43 |
| Wizzup | and if you've ever joined it before it will be in rtcom | 23:43 |
| dsc_ | it wont | 23:44 |
| freemangordon | not if you cleared the group chat before restart | 23:44 |
| dsc_ | only on messages | 23:44 |
| freemangordon | mhm | 23:44 |
| Wizzup | ok then | 23:44 |
| Wizzup | I'd prefer to have as little source as possible, but if it's not realistically possible to avoid | 23:44 |
| freemangordon | so in order to be able to send a new message on a freshly cleared group chat, you need saved settings, IIUC | 23:44 |
| Wizzup | this seems like a very nice thing I think, but ok :D | 23:45 |
| dsc_ | freemangordon: yeah, and we cannot rely on Tp here because IIRC. it will only signal that it is part of channels if the account is online | 23:45 |
| Wizzup | seems like people could just rejoin | 23:45 |
| freemangordon | Wizzup: unless we keep some weird row in rtcom | 23:45 |
| freemangordon | but that'd be a hack I guess | 23:45 |
| dsc_ | registering join events is very annoying for my limit/offset queries :P | 23:45 |
| dsc_ | can do, but will be less performant | 23:45 |
| freemangordon | I can't comment there, you are the ones who know rtcom | 23:46 |
| dsc_ | not just performance, just annoying | 23:47 |
| dsc_ | so in general | 23:47 |
| freemangordon | dsc_: please have a look to what I pushed and perhaps make a new release as there is a fix for a segfault on re-connect | 23:47 |
| dsc_ | ok | 23:47 |
| dsc_ | freemangordon: I would also like some info about your double-GF situation | 23:48 |
| dsc_ | it stays after a restart, yes? | 23:48 |
| freemangordon | yes | 23:48 |
| dsc_ | and its p2p | 23:48 |
| freemangordon | but maybe it is a local issue | 23:48 |
| freemangordon | because I was missing part of p2p patch | 23:49 |
| freemangordon | oops | 23:49 |
| dsc_ | ok | 23:49 |
| freemangordon | part of event_id patch | 23:49 |
| freemangordon | no idea if that matters | 23:49 |
| dsc_ | that patch is irrelevant | 23:49 |
| dsc_ | to this problem | 23:49 |
| dsc_ | I think | 23:49 |
| freemangordon | ok | 23:49 |
| freemangordon | so, I deleted the chat and then sent a message | 23:50 |
| freemangordon | it was not sent | 23:50 |
| freemangordon | but instead I got an error | 23:50 |
| dsc_ | how did you send a new message? via contacts? | 23:50 |
| freemangordon | no, the chat window remained opened I think | 23:50 |
| freemangordon | lemme try to repro | 23:50 |
| dsc_ | Wizzup: did you try chat clear/removal yet? | 23:52 |
| freemangordon | dsc_: ok, delete a chat (that closes the chat window, but leaves the chat in the list), then click on the chat in the list | 23:53 |
| freemangordon | ugh, wait | 23:54 |
| freemangordon | I have some issue with git merge it seems | 23:54 |
| freemangordon | lemme see what's going on | 23:54 |
| dsc_ | delete should: clear rtcom by GROUP_UID, leave the channel (if groupchat), close the window, and remove it from the overview | 23:54 |
| dsc_ | clear should: clear the chat and keep it in the overview | 23:55 |
| freemangordon | delete does not remove p2p chat from the overview here | 23:55 |
| freemangordon | ok, no issue with git | 23:56 |
| freemangordon | it was an issue on my d4, where I was on a wring branch | 23:56 |
| dsc_ | check | 23:56 |
| dsc_ | and after a restart, the p2p chat is probably removed from the overview | 23:57 |
| dsc_ | let me verify | 23:57 |
| dsc_ | ok yep | 23:58 |
| freemangordon | no | 23:58 |
| freemangordon | not here | 23:58 |
| dsc_ | it should remove it from the overview, but it does not (for p2p) | 23:58 |
| freemangordon | as the failed message was put in the db | 23:58 |
| freemangordon | ah, yeah | 23:58 |
| dsc_ | for groupchats, current master works as I intended | 23:58 |
| freemangordon | ok | 23:58 |
| freemangordon | could be | 23:59 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!