| dsc_ | freemangordon: morn | 07:24 |
|---|---|---|
| freemangordon | hi! | 07:25 |
| dsc_ | I implemented online status in overview: https://plak.infrapuin.nl/selif/nw3f3583.png | 07:39 |
| dsc_ | works alright | 07:40 |
| freemangordon | using abook widgets? | 07:40 |
| dsc_ | using abook contact changed signals | 07:41 |
| dsc_ | presence changed* | 07:41 |
| freemangordon | you re-implemented abook contacts list? | 07:41 |
| freemangordon | or that's different | 07:42 |
| dsc_ | this is the conversations chat message overview, not the contact list | 07:42 |
| freemangordon | yeah, I see | 07:42 |
| freemangordon | the point is - do you draw avatar and presence status by yourself? | 07:45 |
| dsc_ | yes :) | 07:45 |
| freemangordon | dsc_: ok, great job | 07:46 |
| dsc_ | if(presence == "available") display(available_icon_thing) :P | 07:46 |
| dsc_ | we can use gtk widgets if they exist I dont care | 07:46 |
| dsc_ | but i will need help | 07:47 |
| freemangordon | I think they exists | 07:47 |
| freemangordon | and they will draw the avatar for you as well :) | 07:47 |
| dsc_ | that would be nice | 07:47 |
| freemangordon | but have to check how exactly | 07:47 |
| dsc_ | this status thing should work for all connection managers that implement the SimplePresence feature | 07:48 |
| dsc_ | i check for it | 07:48 |
| freemangordon | yeah | 07:48 |
| dsc_ | and sending friend requests is only enabled when the CM has TP_QT_IFACE_CONNECTION_INTERFACE_CONTACTS | 07:48 |
| freemangordon | but, which exactly presence do you show? aggregate presence? | 07:49 |
| dsc_ | ? :P | 07:49 |
| freemangordon | heh :p | 07:49 |
| dsc_ | thats up to the server | 07:50 |
| dsc_ | right? | 07:50 |
| freemangordon | no, wait | 07:50 |
| dsc_ | you cant set your status in conversations | 07:50 |
| freemangordon | ok, as we discussed, each contact has at least one master (that can be temp) and zero or more roster contacts | 07:50 |
| dsc_ | this is done via maemo | 07:50 |
| dsc_ | ah | 07:51 |
| freemangordon | so, aggregate presence is that 'best' presence from all the roster contacts | 07:51 |
| freemangordon | so, if you are online on facebook but offline on jabber, the aggregate presence is online | 07:52 |
| freemangordon | do you get the point? | 07:52 |
| dsc_ | yes im just looking at the code currently | 07:53 |
| freemangordon | which code? | 07:54 |
| freemangordon | abook? | 07:54 |
| dsc_ | OssoABookContact *contact = static_cast<OssoABookContact *>(l->data); | 07:55 |
| dsc_ | EContact* e_contact = E_CONTACT(contact); | 07:55 |
| dsc_ | const char* presence = osso_abook_contact_get_value(e_contact, OSSO_ABOOK_VCA_TELEPATHY_PRESENCE); | 07:55 |
| dsc_ | does this use the master contact | 07:55 |
| dsc_ | ? | 07:55 |
| dsc_ | probably not | 07:55 |
| dsc_ | or ehh | 07:55 |
| dsc_ | no idea. | 07:56 |
| freemangordon | you should use osso_abook_presence_get_presence_status(OSSO_ABOOK_PRESENCE(contact)) anyways | 07:56 |
| freemangordon | but lemme check what presence it gets | 07:57 |
| dsc_ | im asking for OSSO_ABOOK_VCA_TELEPATHY_PRESENCE | 07:57 |
| dsc_ | which sounds specific | 07:57 |
| dsc_ | so its probably not the aggregate | 07:57 |
| freemangordon | mhm | 07:57 |
| freemangordon | you can do osso_abook_presence_get_icon_name on the contact | 08:03 |
| freemangordon | and if you provide master contact, you will get aggregate presence | 08:03 |
| freemangordon | if you provide roster contact, then you will get that particular connection presence | 08:04 |
| dsc_ | cool, ill try the icon | 08:06 |
| freemangordon | also, OssoABookContact implements http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/OssoABookAvatarImage.html | 08:06 |
| freemangordon | which you can use directly (as GtkWidget ofc) to show the avatar | 08:07 |
| freemangordon | oops, sorry | 08:07 |
| dsc_ | get_pixbuf 😎 | 08:07 |
| freemangordon | OssoABookContact implements OssoABookAvatar which can be provided to http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/OssoABookAvatarImage.html | 08:08 |
| freemangordon | it is easy to show GtkWidget in qt app | 08:09 |
| dsc_ | yes I am looking at some code | 08:09 |
| dsc_ | it creates a x11 window? | 08:09 |
| freemangordon | umm... no, there was an easier way | 08:10 |
| freemangordon | lemme check | 08:10 |
| dsc_ | https://plak.infrapuin.nl/selif/zwdch3u3.txt | 08:10 |
| freemangordon | no QX11EmbedContainer | 08:10 |
| freemangordon | you can get qt window native id and wrap it to some gtk window, sec | 08:10 |
| dsc_ | sounds a bit crazy :d | 08:11 |
| dsc_ | wrap conversations in a gtk window? | 08:11 |
| freemangordon | no, see https://www.manpagez.com/html/gdk2/gdk2-2.24.24/gdk2-X-Window-System-Interaction.php#gdk-window-foreign-new | 08:12 |
| freemangordon | and https://doc.qt.io/qt-5/qwidget.html#effectiveWinId | 08:13 |
| dsc_ | k | 08:14 |
| dsc_ | no idea whats going on there | 08:14 |
| dsc_ | will have to see later | 08:14 |
| freemangordon | you get XID (effectiveWinId()) from qt and pass it to gdk_window_foreign_new() | 08:15 |
| freemangordon | and you have GdkWindow you can add GtkWidget to | 08:15 |
| freemangordon | simplified | 08:16 |
| freemangordon | I can provide sample code later on | 08:21 |
| dsc_ | ok :) | 08:24 |
| freemangordon | dsc_: I wonder if it is not a time to start implementing 'start chat' functionality, I can provide a simple qt application that does it(the selection part). what do you think? | 08:30 |
| dsc_ | freemangordon: yes, would be nice. it needs to happen from addressbook somehow | 08:31 |
| freemangordon | mhm | 08:31 |
| dsc_ | what do you have in mind? | 08:31 |
| freemangordon | oh, wait | 08:31 |
| freemangordon | I mean - there is 'new message' in the menu | 08:32 |
| dsc_ | yes, I changed it in my current dev branch, but I figure it will be removed because we wil be doing it from abook | 08:32 |
| freemangordon | I think pressing that shall open abook contact searcher | 08:32 |
| dsc_ | yes something like this | 08:32 |
| freemangordon | no, we already can do from abook | 08:32 |
| freemangordon | but my understanding is that we shall be able to start new chat from conversations, no? | 08:32 |
| dsc_ | yes correct | 08:33 |
| dsc_ | need a contact picker | 08:33 |
| freemangordon | exactly | 08:33 |
| dsc_ | if you can spawn this gtk widget/dialog somehow | 08:33 |
| freemangordon | so, my plan is to provide a simple application that implements contact picker in qt | 08:33 |
| dsc_ | yes | 08:33 |
| freemangordon | yes, I can | 08:33 |
| dsc_ | and get the results from it | 08:33 |
| freemangordon | mhm | 08:34 |
| dsc_ | abook is aware of the protocols right? | 08:34 |
| freemangordon | you will get OssoABookContact, when you select one, IIRC | 08:34 |
| freemangordon | sure | 08:34 |
| freemangordon | half of the code deals with TP | 08:34 |
| dsc_ | yes | 08:34 |
| freemangordon | ok, cool | 08:34 |
| dsc_ | let me check @ OssoABookContact, | 08:34 |
| freemangordon | I'll do it as soon as I have some spare time | 08:35 |
| freemangordon | check what? you already use it :) | 08:35 |
| freemangordon | you will get roster contact | 08:35 |
| dsc_ | yes but | 08:35 |
| freemangordon | with remote id and such | 08:35 |
| dsc_ | need to map it to local_uid,remote_uid | 08:35 |
| dsc_ | there is osso_abook_contact_get_persistent_uid | 08:35 |
| freemangordon | map? I think there will be no need to map | 08:36 |
| dsc_ | yes that function will work | 08:36 |
| freemangordon | as you can get TpAccount (the local one) from a contact\ | 08:36 |
| dsc_ | im already using it | 08:36 |
| dsc_ | or that, yeah | 08:36 |
| dsc_ | ok | 08:36 |
| freemangordon | ok, we have a deal | 08:36 |
| dsc_ | xD | 08:36 |
| freemangordon | btw, for the avatar | 08:36 |
| freemangordon | I will also have to provide sample app | 08:37 |
| dsc_ | well | 08:37 |
| freemangordon | but maybe lets do 'new message' first | 08:37 |
| freemangordon | hm? | 08:37 |
| dsc_ | osso_abook_avatar_image_get_pixbuf | 08:37 |
| dsc_ | would be easier | 08:37 |
| dsc_ | no need to include the whole widget this way | 08:37 |
| freemangordon | yeah, but that's GdkPixbuf | 08:38 |
| dsc_ | its just an image, no? | 08:38 |
| dsc_ | yes, I can get the pixeldata from it | 08:38 |
| freemangordon | yes, but it will not update on-the-fly | 08:38 |
| dsc_ | I already listen to updates | 08:38 |
| freemangordon | you have to connect to 'avatar-changed' | 08:38 |
| freemangordon | right, but all this is already implmented | 08:38 |
| dsc_ | i think it would be easier | 08:38 |
| freemangordon | no | 08:38 |
| dsc_ | no need for widget | 08:38 |
| freemangordon | I think it will be way easier to just embed gtk widgets | 08:39 |
| freemangordon | but lets see | 08:39 |
| dsc_ | maybe, the gtk window handle bla stuff seemed a bit convoluted | 08:39 |
| dsc_ | also I need to draw this in a table | 08:39 |
| freemangordon | it is not gtk, but x11 handle | 08:39 |
| freemangordon | XID | 08:40 |
| freemangordon | or 'Window' | 08:40 |
| dsc_ | btw | 08:40 |
| dsc_ | I also need to draw this in QML, possibly | 08:41 |
| dsc_ | for the chatwindow | 08:41 |
| freemangordon | hmm, rigth | 08:41 |
| dsc_ | only the overview is qtwidgets | 08:41 |
| freemangordon | ok, we can cheat then | 08:41 |
| dsc_ | there I will need an image | 08:41 |
| freemangordon | yeah | 08:41 |
| freemangordon | this http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/libosso-abook-osso-abook-avatar.html#osso-abook-avatar-get-image-token | 08:41 |
| dsc_ | its possible to create a custom QML component and override the paint method | 08:42 |
| dsc_ | but... | 08:42 |
| dsc_ | hmm | 08:42 |
| freemangordon | /home/user/.osso-abook/avatars | 08:43 |
| freemangordon | those are the tokens in question | 08:43 |
| dsc_ | nice | 08:43 |
| freemangordon | but, you will have to connect to 'avatar-changed' and re-load whenever needed | 08:43 |
| dsc_ | yes I can see the avatars in that directory | 08:43 |
| dsc_ | ok | 08:44 |
| freemangordon | yeah, this is where abook storest them | 08:44 |
| dsc_ | i will write this code now | 08:44 |
| freemangordon | hmm, wait | 08:44 |
| freemangordon | it is not that simple | 08:44 |
| freemangordon | I think abook does some magic to keep the avatars aspect ration sane | 08:45 |
| freemangordon | lemme check | 08:45 |
| freemangordon | yeah, OssoABookAvatarImage provides fallback image as well | 08:46 |
| freemangordon | dsc_: btw, QML has native window id too | 08:47 |
| freemangordon | but if we draw widget on it, I think we will ruin the performance | 08:47 |
| freemangordon | as it will have to do ReadPixels | 08:47 |
| dsc_ | how do you draw widget on QML though | 08:48 |
| dsc_ | it has scrolling etc | 08:48 |
| freemangordon | no, I mean if we try to embed GtkWidget in it | 08:48 |
| freemangordon | it will be bad perf wise | 08:48 |
| freemangordon | as gtk does SW render | 08:49 |
| freemangordon | while qml does GPU | 08:49 |
| freemangordon | afaik | 08:49 |
| dsc_ | yes | 08:49 |
| freemangordon | so, for SW render, we have to issue glReadPixels | 08:49 |
| dsc_ | im not following how that would work | 08:49 |
| dsc_ | there is a QML surface | 08:49 |
| freemangordon | it will, but will be slow | 08:49 |
| freemangordon | so scratch it | 08:49 |
| dsc_ | ok | 08:49 |
| freemangordon | lets just use images from the filesystem | 08:50 |
| freemangordon | and see what https://github.com/maemo-leste/osso-abook/blob/master/lib/osso-abook-avatar-image.c#L182 and https://github.com/maemo-leste/osso-abook/blob/master/lib/osso-abook-avatar-image.c#L361 do | 08:53 |
| freemangordon | yeah, it does *lots* of things https://github.com/maemo-leste/osso-abook/blob/master/lib/osso-abook-avatar-image.c#L641 | 08:54 |
| freemangordon | it scales and clips and draws shadow and whatnot :) | 08:54 |
| freemangordon | but I guess we can live without those | 08:55 |
| dsc_ | i also get contact changed signal from changing the avatar | 08:55 |
| dsc_ | dont think I need avatar-changed | 08:55 |
| freemangordon | you need | 08:55 |
| freemangordon | because you might have more than one avatar per master contact | 08:56 |
| dsc_ | alright | 08:56 |
| dsc_ | so this signal | 08:56 |
| dsc_ | OssoABookContact *contact = *contacts; | 08:56 |
| dsc_ | its on this? | 08:56 |
| dsc_ | i dont think so | 08:56 |
| dsc_ | because it didnt work :P | 08:56 |
| freemangordon | no, it is on master contacts list | 08:56 |
| freemangordon | from the aggregator | 08:57 |
| dsc_ | right | 08:57 |
| dsc_ | g_signal_connect(conv_abook_aggregator, "avatar-changed", G_CALLBACK(account_avatar_changed_cb), nullptr); | 08:57 |
| dsc_ | like that? | 08:57 |
| dsc_ | i dont know what emits the signal | 08:57 |
| freemangordon | no | 08:57 |
| dsc_ | what object | 08:57 |
| freemangordon | it is per contact | 08:57 |
| dsc_ | its in ./lib/osso-abook-self-contact.c | 08:57 |
| freemangordon | osso_abook_aggregator_list_master_contacts | 08:58 |
| freemangordon | no self contact is your vcard | 08:58 |
| dsc_ | ah | 08:58 |
| freemangordon | or you can do osso_abook_aggregator_find_contacts_full and filter by whatever criteria | 08:59 |
| freemangordon | dsc_: see https://github.com/maemo-leste/osso-abook-home-applet/blob/master/src/osso-abook-home-applet.c#L113 | 09:00 |
| freemangordon | basically home applet gives you example what shall be done for a single contact | 09:00 |
| dsc_ | ugh | 09:01 |
| freemangordon | hmm? | 09:02 |
| dsc_ | nothing | 09:03 |
| freemangordon | so yeah, you can either get pixels from GdkPixbuf or load the files by hand | 09:03 |
| freemangordon | but, there is already some caching, so using osso_abook_avatar_get_image_scaled() might be faster | 09:04 |
| freemangordon | it will also do the cropping for you | 09:05 |
| freemangordon | http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/libosso-abook-osso-abook-avatar.html#osso-abook-avatar-get-image-scaled | 09:05 |
| freemangordon | so you will not need to reimplement all that logoc | 09:05 |
| dsc_ | aparantly I was using | 09:05 |
| dsc_ | GList *contacts = osso_abook_aggregator_list_roster_contacts(conv_abook_aggregator); | 09:05 |
| dsc_ | to get the contacts from abook | 09:05 |
| dsc_ | but I have the use the *master* list | 09:05 |
| dsc_ | so lets see how much stuff I have to change | 09:06 |
| freemangordon | you can get master contact from roster contact | 09:06 |
| freemangordon | wait | 09:06 |
| freemangordon | umm, what do you need roster contacts for? 'contact-changed'? | 09:06 |
| dsc_ | const char* subscribed = osso_abook_contact_get_value(e_contact, OSSO_ABOOK_VCA_TELEPATHY_SUBSCRIBED); | 09:07 |
| dsc_ | const char* published = osso_abook_contact_get_value(e_contact, OSSO_ABOOK_VCA_TELEPATHY_PUBLISHED); | 09:07 |
| dsc_ | const char *persistent_uid = osso_abook_contact_get_persistent_uid(contact); | 09:07 |
| dsc_ | to ask for this stuff | 09:07 |
| freemangordon | ok, so persistent_ui should be the uid of the master contact | 09:08 |
| freemangordon | or, you can do osso_abook_contact_get_master_uids(roster_contact) | 09:08 |
| freemangordon | but, IIRC, you get master contact too with contact-changed | 09:08 |
| dsc_ | this is not changed | 09:09 |
| freemangordon | ah | 09:09 |
| dsc_ | onConnection | 09:09 |
| freemangordon | I see | 09:09 |
| dsc_ | I ask for the roster | 09:09 |
| freemangordon | ok, ok | 09:09 |
| dsc_ | :D | 09:09 |
| dsc_ | btw | 09:09 |
| freemangordon | btw, do not use osso_abook_contact_get_value() | 09:09 |
| freemangordon | osso_abook_presence_get_subscribed() | 09:10 |
| freemangordon | and osso_abook_presence_get_published() | 09:10 |
| dsc_ | im using that in the contacts-changed callback | 09:10 |
| dsc_ | OssoABookPresence *abook_presence = OSSO_ABOOK_PRESENCE(l->data); | 09:10 |
| dsc_ | TpConnectionPresenceType presenceType = osso_abook_presence_get_presence_type(abook_presence); | 09:10 |
| dsc_ | etc. | 09:10 |
| dsc_ | but for the initial roster, not sure how to get this abook_presence | 09:11 |
| dsc_ | anyway | 09:11 |
| dsc_ | this is for later | 09:11 |
| dsc_ | im already happy it works currently | 09:11 |
| freemangordon | OSSO_ABOOK_PRESENCE(contact) | 09:11 |
| freemangordon | also, see http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/OssoABookAggregator.html#osso-abook-aggregator-resolve-master-contacts | 09:11 |
| dsc_ | cool | 09:11 |
| dsc_ | thx | 09:11 |
| dsc_ | wait it returns multiple | 09:12 |
| freemangordon | sure | 09:12 |
| dsc_ | ok so | 09:12 |
| freemangordon | you may have more that one master contact that includes "steve_jobs@whatever.jabber.com", no? | 09:12 |
| dsc_ | im trying to do avatar-changed | 09:12 |
| dsc_ | i need to get the master-contact | 09:12 |
| dsc_ | associated with the initial roster | 09:13 |
| dsc_ | and this master contact can be multiple? | 09:13 |
| freemangordon | mhm | 09:13 |
| freemangordon | just use the first one | 09:13 |
| freemangordon | usually there will be only one | 09:13 |
| dsc_ | alright | 09:13 |
| freemangordon | IIUC | 09:13 |
| freemangordon | ok, have to run, ttyl | 09:13 |
| dsc_ | i will try this `osso_abook_aggregator_list_master_contacts` | 09:15 |
| freemangordon | dsc_: oh, wait | 09:18 |
| freemangordon | you are showing last message, right? | 09:18 |
| dsc_ | yes | 09:18 |
| dsc_ | does this look OK? | 09:19 |
| dsc_ | GList *contacts = osso_abook_aggregator_list_master_contacts(conv_abook_aggregator); | 09:19 |
| dsc_ | for (GList *l = contacts; l != nullptr; l = l->next) { OssoABookContact *contact = static_cast<OssoABookContact *>(l->data); g_signal_connect(contact, "avatar-changed", G_CALLBACK(account_avatar_changed_cb), nullptr); | 09:19 |
| dsc_ | }lol | 09:19 |
| dsc_ | let me paste | 09:19 |
| dsc_ | https://plak.infrapuin.nl/selif/9ptrnt0f.txt | 09:19 |
| dsc_ | because it doesnt work yet | 09:19 |
| freemangordon | then isn't it better to use roster avatar related to the channe this message came from? | 09:19 |
| dsc_ | im just wondering | 09:19 |
| dsc_ | ah yeah | 09:19 |
| dsc_ | good idea | 09:19 |
| freemangordon | mhm | 09:19 |
| freemangordon | the same fot chat window | 09:19 |
| freemangordon | *for | 09:19 |
| freemangordon | so it is even simpler | 09:20 |
| freemangordon | no need to deal with master contacts, sorry for the confusion | 09:20 |
| freemangordon | and the same for presence | 09:20 |
| freemangordon | I got confused :) | 09:20 |
| dsc_ | hmm | 09:21 |
| dsc_ | what do you mean "same for presence" ? | 09:21 |
| dsc_ | ah ok | 09:21 |
| freemangordon | use roster presence, not master | 09:21 |
| dsc_ | so I should use `osso_abook_aggregator_list_roster_contacts` | 09:21 |
| dsc_ | ok | 09:21 |
| dsc_ | or well, I filter the contacts in that loop | 09:21 |
| freemangordon | you already do, no? | 09:21 |
| dsc_ | yes | 09:21 |
| freemangordon | you can filter by using abook | 09:22 |
| freemangordon | just provide filter function | 09:22 |
| freemangordon | see a | 09:22 |
| dsc_ | filter on local_uid would be nice | 09:22 |
| freemangordon | osso_abook_aggregator_find_contacts_full | 09:22 |
| dsc_ | OssoABookContactPredicate | 09:22 |
| freemangordon | or osso_abook_aggregator_find_contacts_for_im_contact | 09:22 |
| dsc_ | i dont know how to use this | 09:23 |
| dsc_ | i want to focus on avatar-changed | 09:23 |
| freemangordon | wait, wtym 'i dont know how to use this'? | 09:23 |
| dsc_ | well | 09:23 |
| dsc_ | I have to look into how to use `osso_abook_aggregator_find_contacts_for_im_contact` | 09:24 |
| dsc_ | or `osso_abook_aggregator_find_contacts_full` | 09:24 |
| dsc_ | and right now I want to do avatar-changed | 09:24 |
| freemangordon | ok | 09:24 |
| dsc_ | and I dont know how to do avatar-changed :P | 09:24 |
| dsc_ | https://plak.infrapuin.nl/selif/9ptrnt0f.txt | 09:24 |
| dsc_ | does this look ok? | 09:24 |
| dsc_ | (apart from using master list) | 09:24 |
| freemangordon | yes, that's it | 09:25 |
| dsc_ | ok cool | 09:25 |
| freemangordon | but I really have to run :) | 09:25 |
| freemangordon | ask Wizzup for help with gtk/glib while I am away | 09:25 |
| dsc_ | (conversations:8645): GLib-GObject-WARNING **: 08:25:15.403: ../../../gobject/gsignal.c:2614: signal 'avatar-changed' is invalid for instance '0x555ee8f551d0' of type 'OssoABookContact' | 09:25 |
| dsc_ | nom nom | 09:25 |
| dsc_ | bye :D | 09:25 |
| freemangordon | well, check what provides "avatar-changed" | 09:25 |
| dsc_ | $ grep -r --include="*.h" 'avatar-changed' /usr | 09:26 |
| dsc_ | nom nom | 09:26 |
| dsc_ | Wizzup: herrow, how to connect to the 'avatar-changed' signal? :P | 09:27 |
| freemangordon | dsc_: https://github.com/maemo-leste/osso-abook-home-applet/blob/master/src/osso-abook-home-applet.c#L236 | 09:35 |
| freemangordon | just use home applet as example | 09:36 |
| freemangordon | if you don't use _swapped, then cb looks like: | 09:37 |
| freemangordon | void notify_avatar_image_cb(OssoABookContact *contact, GdkPixbuf *image, gpointer user_data) | 09:37 |
| freemangordon | umm, wait | 09:38 |
| freemangordon | it is void notify_avatar_image_cb(GObject *gobject, GParamSpec *pspec, gpointer user_data) | 09:40 |
| freemangordon | gobject is the contact that changed the avatar | 09:41 |
| dsc_ | thx it worked | 09:44 |
| dsc_ | freemangordon: I dont think osso_abook_contact_get_avatar() is actually implemented yet | 09:51 |
| dsc_ | http://maemo.org/api_refs/5.0/5.0-final/libosso-abook/OssoABookContact.html#osso-abook-contact-get-avatar | 09:51 |
| sicelo | Wizzup: seems something's not right with how we start alarmd or something ... no rush though. i should be able to look into it the coming days | 09:52 |
| sicelo | but alarm was correctly set and did wake device up when i ran alarmd manually. as run/started by the system, the rtc is never written to | 09:53 |
| sicelo | ah, simple reason - we start alarmd as user. i guess side effect of using rootless xorg, since alarmd is started from xsession? | 09:54 |
| sicelo | this explains why i remember it used to work, presumably when we still ran X11 as root | 10:03 |
| sicelo | mmm | 10:05 |
| sicelo | https://github.com/maemo-leste/bugtracker/issues/754 so I remember | 10:38 |
| Wizzup | let's see | 10:46 |
| Wizzup | I think we give /dev/rtc? a udev rule and a group | 10:47 |
| Wizzup | oh the rtc device is 700 even | 10:47 |
| Wizzup | or, is this wht is even written to by alarm? | 10:47 |
| sicelo | yes, alarmd tries to write to that, https://github.com/maemo-leste/alarmd/blob/84646bc4049c2cc523cb8cb74bf0d1ffb24adece/src/hwrtc.c#L40 | 10:48 |
| sicelo | the whole thing works nicely when you start alarmd manually as root | 10:49 |
| sicelo | but now i see we seem to have always started it as user (not related to rootless xorg). but yeah, as long as rtc is only managed by root (which is generally correct), then we cannot see a hw alarm | 10:51 |
| sicelo | s/cannot see/cannot set/ | 10:53 |
| Wizzup | sicelo: we can make udev rules for all rtc? devices | 13:51 |
| Wizzup | set perms to 0660 and add the users group or some clock group | 13:51 |
| freemangordon | Wizzup: I think we shall start alarmd as root | 16:13 |
| freemangordon | it even complains now on chimaera | 16:13 |
| Wizzup | Why? | 16:17 |
| freemangordon | dsc_: hmm, right, lemme fix that | 16:17 |
| Wizzup | Why run it as root if it is a one linre to make /dev/rtc privs more sensible | 16:17 |
| freemangordon | Wizzup: because we start it from xsession script | 16:17 |
| Wizzup | so why start it as root? | 16:17 |
| freemangordon | isn;t is sytem-wide daemon? | 16:17 |
| Wizzup | that doesn't mean they should run as root | 16:17 |
| freemangordon | or it is per user? | 16:17 |
| freemangordon | so, you want every user session to has it's own alarmd? | 16:18 |
| freemangordon | I don;t think that will work | 16:18 |
| freemangordon | lemme check on which dbus session it registers | 16:18 |
| freemangordon | Wizzup: seems to work on system bus | 16:20 |
| sicelo | i also do think rtc is best managed by root, so i would prefer running alarmd as root as well, leaving rtc permissions intact. less chance that something will try to overwrite the set wakeup time that way. | 16:20 |
| freemangordon | lemme check what it does on fremantle | 16:22 |
| freemangordon | 1352 user 3776 S /usr/sbin/alarmd | 16:23 |
| freemangordon | oh | 16:24 |
| freemangordon | what the? | 16:24 |
| sicelo | and permissions of the rtc? | 16:24 |
| freemangordon | I don't get that https://github.com/maemo-leste/alarmd/blob/master/xsession/03alarmd#L27 | 16:25 |
| freemangordon | crw-rw---- 1 root audio 251, 0 Jan 1 1970 /dev/rtc0 | 16:25 |
| freemangordon | what a mess :) | 16:25 |
| sicelo | lol, audio ... | 16:25 |
| sicelo | so i guess that's how 'user' was able to manage it | 16:26 |
| freemangordon | but, alarmd is started from xsession script with '/etc/init.d/alarmd start' | 16:26 |
| freemangordon | that's... | 16:26 |
| freemangordon | I am speechless | 16:26 |
| sicelo | in Leste, we also do start it via openrc :p | 16:26 |
| freemangordon | yes, but we took that from fremantle | 16:27 |
| sicelo | the openrc? no, we must have made that ourselves | 16:27 |
| sicelo | i actually think now the xsession already finds alarmd running (and thus is a no-op) | 16:27 |
| sicelo | anyway, even the openrc script starts it as user 'user' :-) | 16:27 |
| freemangordon | yes | 16:28 |
| freemangordon | but why? | 16:28 |
| sicelo | i guess we wanted to keep the fremantle behavior. | 16:31 |
| freemangordon | I want to understand why it is run as user before making any decision | 16:31 |
| freemangordon | this does not make any sense to me | 16:33 |
| freemangordon | alarm queue is kept in /var | 16:33 |
| freemangordon | so that is not per user | 16:33 |
| freemangordon | Wizzup: I don;t understand why system-wide daemon should run as 'user' on system bus | 16:43 |
| freemangordon | to me this looks like some ugly hack/overlook made by nokia back then | 16:43 |
| freemangordon | btw, if there is no dsme, it will start as root | 16:44 |
| freemangordon | (talking about original sysv init script) | 16:44 |
| freemangordon | oh, it listens to both system and session bus | 16:45 |
| freemangordon | http://maemo.org/development/sdks/maemo_5_beta_docs/alarm_framework/ | 16:46 |
| freemangordon | http://maemo.org/api_refs/5.0/beta/libalarm/ | 16:48 |
| Wizzup | sorry I was in a work meeting | 16:53 |
| freemangordon | NP | 16:53 |
| Wizzup | I think that the less that runs as root the better | 16:53 |
| Wizzup | /dev/rtc0 is not audio on my droid btw | 16:53 |
| freemangordon | in general I agree | 16:54 |
| freemangordon | no, that's on fremantle | 16:54 |
| Wizzup | and if alarmd only needs roor for /dev/rtc? then we just make a single udev rule | 16:54 |
| freemangordon | so, in general I agree | 16:54 |
| freemangordon | but, what will happen if we have start second user session | 16:54 |
| freemangordon | *started | 16:54 |
| Wizzup | if the second session has access to the system bus then it can talk with it just the same I guess? | 16:55 |
| freemangordon | but it will try to start alarmd again | 16:55 |
| freemangordon | it is the same as if we start mce as user | 16:55 |
| freemangordon | from xsession | 16:55 |
| sicelo | btw why does it need two buses? can it not be on system bus only? | 16:56 |
| freemangordon | no idea | 16:56 |
| freemangordon | that's why I think that's a mess | 16:56 |
| freemangordon | Wizzup: it is not only /dev/rtc | 16:56 |
| freemangordon | it takes care for *all* the alarms in the system | 16:56 |
| freemangordon | which means that 'user' can delete /var/cache/alarm without going through dbus | 16:58 |
| freemangordon | /var/cache/alarmd | 16:58 |
| freemangordon | so, we either move cache dir to $HOME or run as root | 16:59 |
| freemangordon | but, I guess that'd require major changes | 16:59 |
| freemangordon | so yeah, the easiest way to go is rtc permissions | 16:59 |
| freemangordon | dsc_: you don't need osso_abook_contact_get_avatar() as it requires master contact | 17:06 |
| freemangordon | and I think we agreed that you want roster contact avatar | 17:07 |
| sicelo | at least I can confirm that setting 660 permissions, and root:audio ownership on rtc0 does make the UI set alarm properly | 17:39 |
| inky | i dont know if it's only for me, but from time to time i update maemo and try conversations., and whatever i write, reaches the other party, but whatever other party writes, doesn't reach me in conversations. reaches elsewhere. | 18:07 |
| Wizzup | what connection manager is ths? | 18:09 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
