| sicelo | freemangordon: https://paste.debian.net/1336236/ :-) | 00:12 |
|---|---|---|
| sicelo | now hsm.log sees sim and its properties correctly. please commit that | 00:13 |
| sicelo | however, _get_icons() in var/log still says sim status = 0 ... | 00:28 |
| * sicelo heads to bed | 00:28 | |
| freemangordon | sicelo: that does not make change, &s and s should be the same | 06:56 |
| freemangordon | besides the memory allocation | 06:56 |
| sicelo | it made a big difference in the result. also, isn't `{sv}` the dbus signature? i think that doesn't take `&` unless i'm mistaken | 07:05 |
| freemangordon | no, it is gvariant signature | 07:05 |
| freemangordon | and when provided, does not make a copy, IIUC | 07:05 |
| freemangordon | but otherwise should be identical | 07:05 |
| freemangordon | BTW, it this was the issue, I would have seen the same here | 07:06 |
| freemangordon | *if it was | 07:06 |
| freemangordon | I think I know what happens, but need some time to fix it | 07:07 |
| sicelo | sure | 07:10 |
| sicelo | i'll share the hsm.log though | 07:10 |
| freemangordon | BTW, we don;t really care about SIM status in h-s-m | 07:15 |
| freemangordon | we also don;'t care about flightmode | 07:15 |
| freemangordon | status item should display what is the current status | 07:15 |
| freemangordon | sicelo: ^^^ | 07:16 |
| freemangordon | do you agree? | 07:16 |
| sicelo | yes | 07:18 |
| freemangordon | ok, I'll refactor the plugin | 07:18 |
| sicelo | the question is where it gets info from ... clearly _get_icons() is being supplied incorrect info at some point | 07:19 |
| freemangordon | yes | 07:19 |
| freemangordon | but I suspect we have a race in connui_cell_modem_add_simmgr | 07:19 |
| sicelo | https://paste.debian.net/1336263/ | 07:20 |
| freemangordon | SIM PRESENT: 1 | 07:20 |
| freemangordon | is this with & or without? | 07:21 |
| freemangordon | please, add g_debug() to _sim_status_cb() | 07:21 |
| freemangordon | to trace what it is supplied with | 07:22 |
| sicelo | this wad without & | 07:24 |
| freemangordon | check with & | 07:25 |
| freemangordon | I guess you debug that from _parse_property() | 07:25 |
| sicelo | yes, I added it there | 07:25 |
| freemangordon | please revert back to &s | 07:26 |
| freemangordon | maybe you are right, but I wonder why, so lets confirm it | 07:26 |
| sicelo | will do, but a little later | 07:27 |
| freemangordon | ok | 07:27 |
| freemangordon | ok, reproduced it on my d4 | 07:33 |
| freemangordon | hmm, actually no | 07:34 |
| freemangordon | scratch that | 07:34 |
| freemangordon | sicelo: you may use https://pastebin.com/kMTuW4Sq as well | 07:39 |
| freemangordon | oh, wait, despite SIM PRESENT: 1, we still have modem->sim_status: 0 ? | 07:41 |
| freemangordon | sicelo: ^^^? | 07:41 |
| sicelo | yes | 07:53 |
| sicelo | haven't had time to look into why _get_icons is supplied wrong info | 07:55 |
| freemangordon | ok, so no sense to make the '&' test | 07:55 |
| freemangordon | and, removing '&' does not make any difference | 07:56 |
| freemangordon | correct? | 07:56 |
| sicelo | buiilding now with & restored... will report back. I think it did make a difference though, since _parse_property never got to point of parsing the other Sim properties, as it does now | 07:58 |
| freemangordon | this is no because &, that's for sure | 07:59 |
| freemangordon | will hit the isue here if that was the case | 07:59 |
| freemangordon | item code is buggy, refactoring | 07:59 |
| freemangordon | sicelo: please upgrade to see if the issue is fixed | 12:08 |
| freemangordon | hmm, seems modem does not detect SIM inserted here as well sometimes | 12:29 |
| sicelo | freemangordon: works, yay | 13:20 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!