| mason | Hey all. I've got a couple procedural questions. I'm gaining some familiarity with the installer-iso stuff and I put up a PR for a couple additions to the README, but this got me thinking about a variety of things. | 19:21 |
|---|---|---|
| mason | First, from the comment on the PR: "Won't immediately commit it, as I'd like to talk about whether we want to require at least one approval from someone else before things can be merged. The other thing often done is to block direct commits to main, just allowing approved merges. Not sure how much of that we want, so I'll read the tea leaves and just ask." | 19:21 |
| mason | So, with that in mind, what does everyone else think about that kind of gating? In practise, I wouldn't be able to commit to main, I'd commit to a branch and make a PR. Then that PR couldn't me merged until another set of eyeballs whacks the "approve" button, at which point anyone with access could merge it. | 19:22 |
| mason | The other thing that came up is that we can sign commits. Not sure if we can require signed commits or not, but it was pretty easy to set up. I already have my GPG public key uploaded to our Gitea and verified, which Gitea made pretty easy. Actually signing my commit was also easy: git config --global user.signingkey <mykeyID> and then I add an -S to my "git commit". | 19:24 |
| mason | Anyway, food for thought and I'm happy doing whatever makes the most people here happy. My last job forced me way deeper into git than I had been before, and whether it's Stockholm syndrome or not, I came out liking it, and the workflow described (less signing - we didn't do that) worked out pretty well. | 19:25 |
| mason | Sample PR with signed commit is here: https://git.devuan.org/devuan/installer-iso/pulls/16 | 19:26 |
| mason | I'll try to be at the next meeting anyway, in case live discussion is useful. | 19:29 |
| Xenguy | o/ | 19:40 |
| mason | hey there | 19:45 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!